Update label margins to match fieldsets and align with GOV.UK #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandamaryon1
previously approved these changes
May 14, 2024
anandamaryon1
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the bottom margins of labels to better match those of legends. I've followed a bit of how GOV.UK structures these.
At the moment I think the label margins are overly large - too separated from the hint or inputs they relate to. GOV.UK doesn't have responsive margins for these - the label margins are all fixed and the same as the fieldset legends.
The only label that doesn't now match fieldset legends is the small size - where it follows the no modifier size 1.
XL label before
XL label after
L label before
L label after
M label before
M label after
S label before
S label after
No modifier label before
No modifier label after
Fixes #947
Checklist